search

MansMeg / BSDA

An introductory course in Bayesian Statistics and Data analysis at Uppsala University
MIT License
11 stars 5 forks source link

Don't recommend 'monitor' function #6

Closed ninpnin closed 12 months ago

ninpnin commented 1 year ago

Apparently, the 'monitor' that we recommend (Assignment 6) is not really working as it should. It doesn't respond to the number of warmup steps.

Here's a GH issue from three years ago where a Stan dev recommends against it: https://github.com/stan-dev/rstan/issues/759

If this is still the case I think we shouldn't recommend that function to students.

MansMeg commented 1 year ago

Great! Yes, I dont use it myself. Can you do a Pr to fix this?

ninpnin commented 1 year ago

What should we recommend instead? Or should we just remove the hint?

MansMeg commented 1 year ago

What is it used for, traceplots and Rhats and the like? I don't remember.

ninpnin commented 1 year ago

The assignment seems to ask the students for $\hat R$ only:

Screenshot 2023-10-10 at 13 03 37

Then we maybe just remove the recommendation, or alternatively add that you can get the samples for Rhat with the extract function.

MansMeg commented 1 year ago

Yes. I can fix this.

MansMeg commented 12 months ago

Fixed in e9681c0