search

Mantan21 / Genshin-Impact-Wish-Simulator

Best Genshin Impact Wish Simulator Website, no need to download, 100% running on browser!
https://wishsimulator.app
MIT License
197 stars 72 forks source link

Updating rolls.js so that weapons always give 2/10 Starglitter based on rarity, even on their first copy. #67

Closed ScarletSeal closed 1 year ago

ScarletSeal commented 1 year ago

Characters still give 0 Starglitter when they're new, 2/10 when they're C0-C5, and 5/25 when they are C6+, based on rarity

Also, thanks for keeping this app constantly updated! I always come back to it when I'm considering spending my primos, and it's getting better and better every month :)

ScarletSeal commented 1 year ago

Also, I tried implementing Mika and the next banners with placeholder images, 4 stars...and I think it went pretty well? the next banners

I have no experience in coding or github so I'm just going by trial and error, but it seems to be working properly working properly .

Let me know if you would like me to make a pull request when they reveal the banners officially ^^

ScarletSeal commented 1 year ago

I'm going to close the pull request because it accidentally added some files that werent supposed to be there.

AguzzTN54 commented 1 year ago

Usually I will do an update in 1x24h after the banners come out, so I would be grateful if you can help me. Do whatever you can, I really appreciate it but I'll add some adjustment if needed.

ScarletSeal commented 1 year ago

Oh that's great news, I'll gladly help you out!! Actually, let me start working on indexing Mika right away, to make sure he works in every language :)

I'll try to follow your model as best as I can, to hopefully reduce how many adjustments you'll have to make once the pull request comes out.

Also, there's a few things I want to try and improve (?)

1) The quality of "static/videos/5star.mp4". It stutters a bit in the first few milliseconds, giving away the wish result before the meteor turns gold. My plan is to record my own wish screen and edit out my IUD the next time I get a 5 star (?) but I'm not sure it will work too well;

2) The epitomized path counter updates as soon as you click the wish button, before the meteor video even appears, giving away the wish result before you see which weapon you got. I haven't found a way to fix this yet, mostly because I have ZERO experience, but who knows, maybe it won't be too much trouble and I'll learn a new thing;

3) The Starglitter thing that's already in this pull request.

ScarletSeal commented 1 year ago

Update: Done editing 5star.mp4, done with Mika, and I made this in case you need it in the future Weaponbanner

AguzzTN54 commented 1 year ago

2. The epitomized path counter updates as soon as you click the wish button, before the meteor video even appears, giving away the wish result before you see which weapon you got. I haven't found a way to fix this yet, mostly because I have ZERO experience, but who knows, maybe it won't be too much trouble and I'll learn a new thing;

About the epitomized path, I will try to find how to solve it, it's little bit complicated.