Mantan21 / Genshin-Impact-Wish-Simulator

Best Genshin Impact Wish Simulator Website, no need to download, 100% running on browser!
https://wishsimulator.app
MIT License
197 stars 72 forks source link

Shenhe-Ayaka Banner added to the simulator #74

Closed ScarletSeal closed 1 year ago

ScarletSeal commented 1 year ago

Let me know if there's anything I need to change :) Changelog: -Added the new banners (Ayaka, Shenhe, Epitome-44) -Added images, as webp, for the banners and the thumbnails -Moved the text "lonesome transcendence" so it matches with the banner image -Implemented Mika in every language that supports items. -Opening the site sends you to Ayaka's banner straight away

AguzzTN54 commented 1 year ago

image

And one more thing, I hope you can explain what changes you made to each commit to make it easier to manage the code, not just random messages like this.

ScarletSeal commented 1 year ago

-Shenhe, Ayaka, Mistsplitter buttonBox were copied 1:1 as you requested -Queller buttonBox was copied as well, but also moved 30 units to the right so that it appears next to Mistsplitter -Added Mika splashes in their respective folders -Wine and Song now appears as the first weapon instead of The Bell -storageVersion 3.5.0->3.5.1

I named the new commits, and added descriptions for easier readability. Old commits are a mess because I deleted my old repository that time, so I was just trying to get back to where I was before deletion.

AguzzTN54 commented 1 year ago

I named the new commits, and added descriptions for easier readability. Old commits are a mess because I deleted my old repository that time, so I was just trying to get back to where I was before deletion.

This is not a problem I mean if you have plans to create more pull requests in the future, you can do it better.

AguzzTN54 commented 1 year ago

After double checking, I just realized that Shenhe's banner has different aspect ratio from the others and webpage screenshot still not updated yet. I have fixed these issues as I update the changelog. I've pushed to the production server, as far as I can tell everything is running fine right now because of your help.

Thanks for your hardworking, I really appreciate.