search

MantisAI / nervaluate

Full named-entity (i.e., not tag/token) evaluation metrics based on SemEval’13
MIT License
154 stars 19 forks source link

README error #54

Closed fgh95 closed 2 years ago

fgh95 commented 2 years ago

Hi,

Thanks a lot for maintaining this great tool!

A small note on the README: I think there is a typo when defining the Recall of the partial match: 

Precision = (COR + 0.5 × PAR) / ACT = TP / (TP + FP)
Recall = (COR + 0.5 × PAR)/POS = COR / ACT = TP / (TP + FP) # here

I believe it should be 

Recall = (COR + 0.5 × PAR)/POS = COR / ACT = TP / (TP + FN) # here
ivyleavedtoadflax commented 2 years ago

Thanks @fgh95, if you have a moment, please feel free to make a PR to fix, otherwise I will resolve later in the week.

fgh95 commented 2 years ago

Great, just made the PR: #55