search

MantisAI / nervaluate

Full named-entity (i.e., not tag/token) evaluation metrics based on SemEval’13
MIT License
154 stars 19 forks source link

Solved issue #40 #70

Closed infopz closed 11 months ago

infopz commented 1 year ago

Solved issue #40. When two true entities were predicted as one, the classification differs based on the input list order

ivyleavedtoadflax commented 1 year ago

Thanks for this @infopz . Are you able to add a test for this please :pray:

infopz commented 1 year ago

Test added 👍

ivyleavedtoadflax commented 1 year ago

@infopz can you merge #71 into this, to see if it resolves the failing CI/CD please

infopz commented 1 year ago

Merged 👍

davidsbatista commented 11 months ago

Thanks for contributing - there's a failing issue but I will look into it.

infopz commented 11 months ago

Hi, can I do something to fix this?

davidsbatista commented 11 months ago

I'm planning to do it at the weekend., but if you want please, go ahead :)

infopz commented 11 months ago

It seems a permission problem on your side remote: Permission to MantisAI/nervaluate.git denied to github-actions[bot]. but if this depends on something I can do, feel free to ask

davidsbatista commented 11 months ago

The PR LGTM, it's just the issue with the CI/CD now - @ivyleavedtoadflax do you have any idea what might be causing that?

ivyleavedtoadflax commented 11 months ago

I believe it is failing because the PR is originating from a fork which defaults to read access, but the coverage action needs write access to push to the repo.

/usr/bin/git push --force ***github.com/MantisAI/nervaluate.git github-pages-deploy-action/pcenusi52:coverage-badge
remote: Permission to MantisAI/nervaluate.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/MantisAI/nervaluate.git/': The requested URL returned error: 403

I'll merge for now, and that will resolve it, but not sure the best way to resolve going forward.

ivyleavedtoadflax commented 11 months ago

Could also be that we can set the pages permission to write as here https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#defining-access-for-the-github_token-scopes