Mantle / MTLManagedObjectAdapter

Core Data support for Mantle
https://github.com/Mantle/Mantle
MIT License
140 stars 55 forks source link

Building error on Xcode 6.3 #8

Closed hankbao closed 8 years ago

hankbao commented 9 years ago

Got this error when using carthage to integrate MTLManagedObjectAdapter:

MTLManagedObjectAdapter/MTLManagedObjectAdapter.m:754:41: error: comparison of array 'attributes->type' not equal to a null pointer is always true

attributes->type != NULL

It seems that changing type from char[] to char* can fix this error. So this may actually relate to libextobjc.

jspahrsummers commented 9 years ago

This is a legitimate warning/error. A NULL comparison is useless because the character array is embedded in the structure allocation itself.

But, ideally, this would be fixed upstream in libextobjc. :wink:

hankbao commented 9 years ago

I see. Thanks for your reply.

sunkehappy commented 9 years ago

When could this be fixed? I don't like warnings. Thanks.

gus-byrnesinnovation commented 8 years ago

+1 is this in the works?

jspahrsummers commented 8 years ago

Please do not +1 issues. If you want to see it fixed sooner, please submit a pull request (upstream to libextobjc, as mentioned).

grgcombs commented 8 years ago

I believe this is fixed by #23 now.

jspahrsummers commented 8 years ago

Yep, thanks!