search

Manuel-K / devilutionX-QOL-patches

QOL improvements for devilutionX
25 stars 4 forks source link

Project name patch doesn't apply #6

Closed AJenbo closed 4 years ago

AJenbo commented 4 years ago

This is no longer statically set. https://github.com/Manuel-K/devilutionX-QOL-patches/blob/62936e60761bb8a341a9765a33d06d9e890c4425/mk_menu_label_01.patch#L13

Instead it gets applied (taken from CMakeList.txt) here: https://github.com/diasurgical/devilutionX/blob/c0e511265d775d27028e2014aed333636c85371b/Source/init.cpp#L113

Manuel-K commented 4 years ago

Even worse, it says devilutionX-v1.0.0 for 1.0.1.

Manuel-K commented 4 years ago

Aha. You moved the tag.

Manuel-K commented 4 years ago

Now it says “devilutionX v1.0.0 with QOL changes”. I can't get it to say 1.0.1.

AJenbo commented 4 years ago

You have to rerun cmake to pick up the version from git tags.

Manuel-K commented 4 years ago

I edited config.h manually.

Manuel-K commented 4 years ago

Thank you for the report.

AJenbo commented 4 years ago

Sounds good, as just be aware that config.h might be regenerated (based on git) when the CMake cache expires.

arrowgent commented 4 years ago

mine just says "DevilutionX v with QOL changes"

using v1.0.1

Manuel-K commented 4 years ago

Are you using a git checkout or did you download an archive of devilutionX? @AJenbo, do you have any idea?