Use Granite.Widgets.About

[danirabbit]

We made a sexy stock About dialog with all the things elementary OS users expect to see. It would be great for Go For It! to be consistent with the system in using this dialog

[Manuel-Kehl]

Thanks for the hint @danrabbit. As Go For It! doesn't rely on any of the "more advanced features" of Granite, like its special tabs or date / timer pickers, I wanted to avoid that dependency, if possible. It simply is not available on all of the most common distributions yet and as much as I love elementary myself, I want Go For It! to be a usable and pleasant tool and many OSes.

In #17 @voldyman already transitioned to the Gtk.About dialog, which is a lot more beautiful, than my old implementation :smiley: Even though it's a bit different, I'd personally say that it looks almost as nice as the Granite version and fits in well:

If you think that #17 is still not acceptable form an "elementary point of view", we could try to solve the problem by abstracting the about dialog and building two different versions: One with and one without granite dependencies. Let me know, what you think ;-)

[danirabbit]

Well Gtk.About doesn't provide all the same things as Granite.About does. Granite.About includes links to suggest translations and report a problem as well as where to get help.

I would warn that cross platform is the path to the dark side. But good luck :)

[fredmwangi]

What it would look like @danrabbit @mank319 :

[fredmwangi]

scrolling:

[Manuel-Kehl]

@fredmwangi it looks very nice indeed.

[Manuel-Kehl]

I have made up my mind about how to solve the "Granite vs No-Granite" issue in that particular case:

• [ ] The constructor of AboutDialog shall accept a list of all the necessary fields; especially those that change regularly, like version
• [ ] Duplicate AboutDialog.vala to AboutDialog_no_granite.vala
• [ ] Replace Gtk.AboutDialog with Granite.AboutDialog in AboutDialog.vala
• [ ] Define a rule in CMakeLists.txt that determines, whether or not the Granite build dependencies are available and therefore decides whether or not to include AboutDialog.vala or AboutDialog_no_granite.vala

This way I can simply set up another PPA, with elementary (and thus Granite) dependencies for us elementary users and leave the other one for the rest of the (Ubuntu based) world. If Granite is included in a future version of Ubuntu, the Launchpad buildbot will automatically use the Granite version, without us applying any changes. And for those who compile themselves it will work magically :+1:

This will keep the maintenance overhead as low as possible!

[Manuel-Kehl]

Unfortunately I am currently in an exam period and thus don't have much time for changes like that. That being said it should not be much work, if you know your way around CMake (at least I hope so :wink: ).

Pull requests and feedback are welcome!

[JMoerman]

Implemented in 23cc02111af46944f27fb7394d34ec7a3e0c92dc.