Manuel-Kehl / elementaryPlus

This theme is an addition to elementary OS's default icon theme. It contains icons for several third party applications that resemble elementary OS's style.
GNU General Public License v3.0
356 stars 35 forks source link

Icon Request: Rambox #431

Open FESJ opened 7 years ago

FESJ commented 7 years ago

Hey,

an indicator-icon for Rambox (Website, Github) would be great, the original one looks awful :)

Thanks & have a nice day :)

caio-hungria commented 7 years ago

Yes, please.

yerbestpal commented 7 years ago

This would be great. Messengerfordesktop has WM_CLASS issues that I can never fully resolve and Rambox is way more convenient.

bilelmoussaoui commented 7 years ago

@yerbestpal you can use this small bash script to fix WM_CLASS issues. https://github.com/bil-elmoussaoui/StartupWMClassFixer If the app you're using is not supported just check the readme and you will be able to fix it pretty easily

yerbestpal commented 7 years ago

Thank you very much, that was a great help.

bilelmoussaoui commented 7 years ago

@yerbestpal can you please open a PR with the entry for MessengerForDesktop? as it seems to not be supported :) Thanks!

yerbestpal commented 7 years ago

@bil-elmoussaoui For StartupWMClassFixer? It worked perfectly for me. The output said it fixed Chrome, but Chrome wasn't broken and it seemed to fix MessengerForDesktop.

bilelmoussaoui commented 7 years ago

@yerbestpal Not possible as there's nothing about MessengerForDesktop here https://github.com/bil-elmoussaoui/StartupWMClassFixer/blob/master/database.csv :p

yerbestpal commented 7 years ago

@bil-elmoussaoui I don't know what to say. Yesterday I installed MessengerForDesktop and had double/blurry icons. Today (after a fresh OS install) I installed again then ran StartupWMClassFixer and there are no icon issues. I also don't have a clue how to make pull requests. screenshot from 2017-03-12 12 03 32

caio-hungria commented 7 years ago

I found this https://github.com/numixproject/numix-icon-theme/blob/master/Numix/22/status/rambox-indicator.svg for the Rambox indicator icon. How can I replace the one running right now?

bilelmoussaoui commented 7 years ago

@caio-hungria Install https://github.com/bil-elmoussaoui/Hardcode-Tray And run hardcode-tray --size 22 --apply --only rambox --theme Numix --change-color "#ececec #ffffff"

caio-hungria commented 7 years ago

@bil-elmoussaoui Thank you very much, that worked perfectly! One last question, could I change Dropbox, Rambox and Redshift icons to black color, so they look match elementary black icons?

bilelmoussaoui commented 7 years ago

It's not possible. Elementary uses symbolic icons (icons that can be styled using CSS) which isn't the case for the rest of the tray icons. It must be supported upstream by those apps that you have listed

caio-hungria commented 7 years ago

Got it. Thank you again. That indicator icon was really disturbing.