ManuelDeLeon / viewmodel-react

Create your React components with view models.
MIT License
24 stars 3 forks source link

React v15.3.2 giving dependency errors #14

Closed fvpDev closed 7 years ago

fvpDev commented 7 years ago

Maybe have viewmodel be dependant on react 15.3.1 rather than ^15.3.1? Or if you can help me/us, how would we get rid of these errors? http://stackoverflow.com/questions/39692025/what-is-causing-the-npm-dependency-warning Wait, might be answered here: http://stackoverflow.com/questions/37312749/warning-npm-peer-requirements-not-installed-react15-0-2-installed-react0-14?rq=1

ManuelDeLeon commented 7 years ago

The solution is to have a peer dependency on react, not a hard one. I don't know which react is the lowest it works with, I think it's 15.2.0

On Oct 18, 2016 4:46 PM, "Fedor Parfenov" notifications@github.com wrote:

Closed #14 https://github.com/ManuelDeLeon/viewmodel-react/issues/14.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ManuelDeLeon/viewmodel-react/issues/14#event-828271343, or mute the thread https://github.com/notifications/unsubscribe-auth/AED31g-9HC6Djap9A1207ibBlrQ96ddxks5q1UxLgaJpZM4KaX3D .

ManuelDeLeon commented 7 years ago

I'll update it later tonight.

On Oct 18, 2016 4:55 PM, wrote:

The solution is to have a peer dependency on react, not a hard one. I don't know which react is the lowest it works with, I think it's 15.2.0

On Oct 18, 2016 4:46 PM, "Fedor Parfenov" notifications@github.com wrote:

Closed #14 https://github.com/ManuelDeLeon/viewmodel-react/issues/14.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ManuelDeLeon/viewmodel-react/issues/14#event-828271343, or mute the thread https://github.com/notifications/unsubscribe-auth/AED31g-9HC6Djap9A1207ibBlrQ96ddxks5q1UxLgaJpZM4KaX3D .

fvpDev commented 7 years ago

Well, I don't think it was a vm-react issue at all

ManuelDeLeon commented 7 years ago

Even then, it should be a peer dependency (It should work with the React version you have). Another reason is that it will help make it work with React-Native.

I just published 0.8.11 which has that change.