search

ManuelHentschel / vscode-github-linker

VS Code extension to create and open GitHub links
https://marketplace.visualstudio.com/items?itemName=manhen.github-linker
MIT License
1 stars 1 forks source link

Extension doesn't work on remote workspaces #7

Closed pippinsoft closed 1 year ago

pippinsoft commented 1 year ago

The extension works great on local workspaces (thanks!!!).

On remote workspaces I get the following error:

Could not copy GitHub URL: Git extension not installed or not activated yet!

I confirmed that the builtin git extension is installed globally.

This is true for multiple workspaces, both local (works) and remote (error), across multiple local and remote machines (all running Linux). Please let me know if I can provide any further information.

ManuelHentschel commented 1 year ago

I wasn't able to reproduce on WSL, but I found the option to add an "extensionDependency" in the description of the vscode.git extension and fixed a deprecation warning. These changes are published (v0.0.12), does this update change anything w.r.t. your issue?

pippinsoft commented 1 year ago

Thanks for the quick response, but that did not work. I noticed that VSCode reports that the extension is running locally because it prefers to do so. I removed ui from extensionKind and that solved the problem.

https://github.com/ManuelHentschel/vscode-github-linker/blob/cd2e189f3e03a28e48bf999fcfd1d3ffcad7f727/package.json#L9-L12

Perhaps switching to "extensionKind": ["workspace", "ui"] as described here: https://code.visualstudio.com/api/advanced-topics/extension-host#preferred-extension-location would work; I have not yet tested that.

ManuelHentschel commented 1 year ago

Good catch! I removed the entry now (not sure why I put it there in the first place). This change makes the extension work on the remote SSH that I tested.

pippinsoft commented 1 year ago

Thanks for the quick fix! It works for me on local and remote.