ManukMinasyan / vue-functional-calendar

Vue.js Functional Calendar | Component/Package
https://vue-functional-calendar.now.sh/
MIT License
467 stars 84 forks source link

Make component imports explicit by adding .vue extension #143

Closed MikeEtlingerRM closed 2 years ago

MikeEtlingerRM commented 2 years ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch vue-functional-calendar@2.9.5 for the project I'm working on.

We are migrating our Vue project to use ViteJS and one of the requirements is that Vue components must have explicit import extensions for Single File Components. That means the imports in this package break local development in that scenario.

I'm happy to put up a PR for this trivial change but let me know if you have any concerns.

Thanks!

Here is the diff that solved my problem:

diff --git a/node_modules/vue-functional-calendar/src/components/FunctionalCalendar.vue b/node_modules/vue-functional-calendar/src/components/FunctionalCalendar.vue
index dae7411..fc7a87a 100644
--- a/node_modules/vue-functional-calendar/src/components/FunctionalCalendar.vue
+++ b/node_modules/vue-functional-calendar/src/components/FunctionalCalendar.vue
@@ -217,13 +217,13 @@
 <script>
 import helpCalendarClass from '../assets/js/helpCalendar'
 import { propsAndData } from '../mixins/propsAndData'
-import TimePicker from '../components/TimePicker'
-import Arrows from '../components/Arrows'
-import WeekNumbers from '../components/WeekNumbers'
-import Day from '../components/Day'
-import MonthYearPicker from '../components/MonthYearPicker'
-import PickerInputs from '../components/PickerInputs'
-import Footer from '../components/Footer'
+import TimePicker from '../components/TimePicker.vue'
+import Arrows from '../components/Arrows.vue'
+import WeekNumbers from '../components/WeekNumbers.vue'
+import Day from '../components/Day.vue'
+import MonthYearPicker from '../components/MonthYearPicker.vue'
+import PickerInputs from '../components/PickerInputs.vue'
+import Footer from '../components/Footer.vue'