Maoni0 / realmon

A monitoring tool that tells you when GCs happen in a process and some characteristics about these GCs
MIT License
281 stars 25 forks source link

[Feature] .gcmon Config File #35

Open workgroupengineering opened 2 years ago

workgroupengineering commented 2 years ago

Allow dotnet-gcmon to recursively crawling the configuration file like .editorconfig

MokoSan commented 2 years ago

@workgroupengineering, could you please clarify what you mean by "recursively crawling configuration"? From my understanding, .editorconfig allows to override behavior based on the folder you are in. I am missing how adding different config files to different directories will help override the logic. Unless you meant: if changes are dynamically added, the process should automatically pick it up using an abstraction like the FileWatcher?

workgroupengineering commented 2 years ago

dotnet-gcmon first checks the current directory if .gcmon exists, if not found it recursively searches the parent folder until it is found or arrived to the root of the volume. If no .gcmon was found, default configuration is used.

Maoni0 commented 2 years ago

can you please explain what would be the value of providing this? we already have the option to allow the user to specify a config of their choice.

workgroupengineering commented 2 years ago
Maoni0 commented 2 years ago

we already have a default config file so you don't need to specify a config on the commandline unless you want to change it. most users would use that config file. the scenario you illustrated is only for folks who actually do development on the tool which is a very small percentage. so introducing yet another config doesn't seem warranted. it's another config for the tool to maintain/care about.