Closed stellaraccident closed 13 years ago
I like the idea of moving the SQL into separate files - anything that can be done to reduce duplication. I've reverted the bit that's adding spaces around road names for the moment, but I'd be interested in seeing what the result of your experiments with name density are.
I've also pulled in a bunch of changes we had staged (sorry, should have pushed them earlier and not in a big lump like this) which I hope won't have too much of a knock-on effect on what you're working on.
Thanks again!
Hi there, Could you have a look at this commit: https://github.com/stellaeof/MapQuest-Mapnik-Style/commit/1eefe592718737f8031a81eaf6128b069eae643e
There are three things going on here. The first one, I think should definitely be finished and make it into your repo. The other two have helped me out but you may or may not want them. Sorry to have committed them in one go:
Several of these changes were motivated by a tool I am using that discovers commonalities in the map data and coalesces it on disk. It works better if you have less arbitrary sql running around since it can clearly determine that different layers are referencing the same data. The tool also can be used to generate different detail level batches by simplifying all of the data in one go for higher scale rendering. With that said, even if you are not using this optimization tool, I think these changes are in line with good map file design and should be taken.