MapQuest / MapQuest-Mapnik-Style

MapQuest Branded style for use with Mapnik and OSM
open.mapquest.co.uk
93 stars 25 forks source link

Road names don't fit into symbols #8

Open FewKinG opened 12 years ago

FewKinG commented 12 years ago

Hey, I'm using the mapquest (non-hybrid) eu style to render maps of Germany with mapnik2. I did not modify the styles (except for the templates to match my render setup). But for me the street names for larger roads which should fit into the square road symbols are positioned incorrectly and rotated to match the direction of the road (which they shouldn't be) as you can see here:

http://imageshack.us/photo/my-images/687/mapqueststyle.png/

I don't know whats wrong there, can you help me out a bit?

springmeyer commented 12 years ago

This may be a mapnik regression - likely not a problem with the stylesheet. What mapnik version are you using? /cc @herm

FewKinG commented 12 years ago

I'm running on ubuntu 10.04 and am using the nightly build packages (mapnik2.0). I know these are prone to errors as they are not actual releases. So this might very well be an error or change on their side. Maybe I should try to build from the stable release and report back to you.

herm commented 12 years ago

Could be related to https://github.com/mapnik/mapnik/issues/1078.

springmeyer commented 12 years ago

Okay, right if you are using the nighties that means you are running code that includes a very recent large refactoring of text placement. You likely want to follow https://github.com/mapnik/mapnik/issues/1078 which I think is related and should be fixed shortly.

FewKinG commented 12 years ago

The referenced issue (1078) is not exactly related. It pointed me to the solution though. I had to change the placement attribute in the ShieldSymbolizers from placement="line" (which aligns the text with the road) to placement="point"

This makes sense to me and I wonder if this also only changed in one of the later releases. Any idea if these adjustments should be applied to the mapquest repository?

herm commented 12 years ago

Should be fixed in mapnik/a05faceb11d1798eb708b1b0e23c08af51896f0a.

FewKinG commented 12 years ago

Ah okay, thanks a lot for your efforts. I will try out tonight's build tomorrow.