search

MapServer / MapServer-import

3 stars 2 forks source link

[Context] context 1.0 write code uses WMS instead of OGC:WMS #1693

Open tbonfort opened 12 years ago

tbonfort commented 12 years ago

Reporter: bartvde@osgis.nl Date: 2006/03/01 - 08:07

When outputting a WMC, Mapserver uses WMS for the value of the service
attribute of Server, whereas the OGC example (on schemas.opengis.net) as
well as Ionic use OGC:WMS

<Server service="OGC:WMS"

See also the example in the OGC WMC 1.0 spec:
http://www.opengeospatial.org/docs/03-036r2.pdf
tbonfort commented 12 years ago

Author: jlacroix Date: 2006/03/01 - 16:45

Note this is fixed in WMC 1.1 support.
Before that, the WMC only specified "string" as the type for the Server's
service parameter. If I remember well, we write only "WMS" because at the time
the context support was developped "OGC:WMS" was not used anywhere (version
0.1.4 at the time). So I'm not sure from which version we should change it to
"OGC:WMS".

Also since in 1.0.0 specify only the string type it's legal to use "WMS"...

What do you think?
tbonfort commented 12 years ago

Author: bartvde@osgis.nl Date: 2006/03/01 - 18:37

Hi Julien,

what Mapserver does is valid according to the schema, that's true. But I think
it would be more wise to follow the examples from the specification document
though, only ofcourse if it won't break backward compatibility which I don't
think it does (since the Ionic OGC:WMS in the WMC 1.0 document was parsed
correctly to CONNECTIONTYPE WMS).

Bart
tbonfort commented 12 years ago

Author: dmorissette Date: 2006/03/27 - 15:30

Reassigned to Julien.
tbonfort commented 12 years ago

Author: tomkralidis Date: 2007/04/28 - 14:07 It looks like this has been done (see mapcontext.c, line 1940). Julien: can you verify?

tbonfort commented 12 years ago

Author: bartvde Date: 2007/04/29 - 14:32 Replying to [comment:4 tomkralidis]:

It looks like this has been done (see mapcontext.c, line 1940). Julien: can you verify?

Hi Tom, it has not been done yet (see http://cvs.gis.umn.edu/cgi-bin/viewcvs/mapserver/mapcontext.c?rev=1.81&content-type=text/vnd.viewcvs-markup). For WMC 1.1 it outputs OGC:WMS, but for WMC 1.0 it outputs WMS instead of OGC:WMS. I think we should use OGC:WMS also for WMC 1.0, but Julien and I did not agree on that part if I remember correctly.

tbonfort commented 12 years ago

Author: tomkralidis Date: 2007/04/30 - 13:53 Ah, ok. I misunderstood this one. :)

OK, if we set Server/@service"OGC:WMS" for 1.0.0 and 1.1.0, I think that's fine. I don't know that alot of clients actually use the value when binding as opposed to an identifier. Infact, I think this attribute may have originally been a placeholder for future versions of WMC which may support other OGC types.

Julien: is this okay with you?

tbonfort commented 12 years ago

Author: jlacroix Date: 2007/04/30 - 19:53 Thanks for the precision. I updated the code to write "OGC:WMS" for the 1.0.0 version. I left previous versions use "WMS" because the examples in those documents used "WMS".

Marking as FIXED

tbonfort commented 12 years ago

Author: jlacroix Date: 2007/04/30 - 19:55 BTW, I updated only the SVN head version. Should it be back ported to 4.10?

tbonfort commented 12 years ago

Author: bartvde Date: 2007/04/30 - 19:59 I think svn head is fine.