search

MapServer / MapServer-import

3 stars 2 forks source link

Support for dispatching multiple errors (mapscript) #1704

Open tbonfort opened 12 years ago

tbonfort commented 12 years ago

Reporter: szekerest Date: 2006/03/09 - 00:56

Sean,

I have created the patch to support multiple errors to be posted to the SWIG
bindings. Only C# supports inner exceptions (SWIG 1.3.29) the others will get
the messages concatenated. Some languages are handling exceptions separately
this patch only applies to the languages using maperror.i

Notes:
1. I have corrected msGetErrorString since it truncated the long messages
curiously. (The postgis driver is not scrimpy for example)
2. maperror.i supports only 8192 as the max. length of the message (controlled
by #define) since it is almost impossible to use SWIG_exception with dynamically
allocated strings. The release logic of the string could be written language
dependently.
3. C# exception handling has been fully redefinied
4. Added a new function to maperror.c to retrieve the displayable error message
independently.

I hope it will help folks to find the problems more quickly. "Failed to draw
layer" was cumbersome a bit.

Best Regards,

Tamas
tbonfort commented 12 years ago

Author: szekerest Date: 2006/03/09 - 01:00


Added Steve as CC because the C library is to be changed
tbonfort commented 12 years ago

Author: sdlime Date: 2006/03/13 - 18:25

Sean: Any comments on this?

Steve
tbonfort commented 12 years ago

Author: sgillies@frii.com Date: 2006/03/14 - 17:09

I'd like to test it out before it's committed, but I like the idea a lot.
tbonfort commented 12 years ago

Author: sdlime Date: 2006/03/14 - 17:38

I'll apply the patch then this evening and we can give it a shot.

Steve
tbonfort commented 12 years ago

Author: szekerest Date: 2006/03/17 - 00:22


Comitted to CVS HEAD
tbonfort commented 12 years ago

Author: szekerest Date: 2006/03/19 - 20:53


Committed to Branch-4-8
tbonfort commented 12 years ago

Author: szekerest Date: 2006/03/19 - 21:05


Marking as fixed now
tbonfort commented 12 years ago

Author: sdlime Date: 2006/03/20 - 16:17

Any impacts to PHP/MapScript? Is there any potential to break existing scripts?

Steve
tbonfort commented 12 years ago

Author: hobu Date: 2006/03/22 - 18:21

This has to be rolled back out of the MapServer 4.8 branch.  Something is
causing every Python mapscript function to throw an exception now.  This blocks
our release until it is resolved.
tbonfort commented 12 years ago

Author: sgillies@frii.com Date: 2006/03/22 - 18:38

Tamas, this feature is good for the CVS HEAD, but we shouldn't make these kind
of changes to our release branches. In my opinion, 4.8.x should be frozen except
for bug fixes.
tbonfort commented 12 years ago

Author: hobu Date: 2006/03/22 - 18:54

I'm an idiot.  I had a typo in my PROJ_LIB environment variable that was causing
every mapObj open to throw an exception.  Things look fine.  The issue of
whether or not this stuff should remain in a stable branch still stands.
tbonfort commented 12 years ago

Author: szekerest Date: 2006/03/22 - 22:02


Reverted mserror.i to avoid any possible problems with java and ruby. For C# it
was substantially tested.

maperror.c and maperror.h should remain since bug fix were made there and was
tested thoroughly.

the csharp stuff csmodule.i should also remain.

Tamas
tbonfort commented 12 years ago

Author: sgillies@frii.com Date: 2006/06/02 - 04:20

reassigning.
tbonfort commented 12 years ago

Author: sdlime Date: 2009/09/02 - 05:40 Tamas, is this still a relevant ticket? Just cleaning house.

Steve