search

MapServer / MapServer-import

3 stars 2 forks source link

Leak of classes in mapogcsld.c and mapogcfilter.c #2168

Open tbonfort opened 12 years ago

tbonfort commented 12 years ago

Reporter: dmorissette Date: 2007/07/20 - 23:08 Assefa, while working on ticket #302, I noticed a few places in mapogcsld.c and mapogcfilter.c that seem to be leaking the contents of existing classes in the layers on which sld/filters are applied.

The places that I spotted are marked by a TODO comment in c2efa45b233b28a984454a35a1f8be9227548044 (r6360).

Can you please review those comments and confirm that getting rid of existing classes if really the intended behavior. If yes then I will implement a function to clear all classes in a clean way since just calling initClass() on an existing class doesn't free existing members and ends up leaking memory.

tbonfort commented 12 years ago

Author: assefa Date: 2007/07/20 - 23:41 I have checked the spots and that intenstion freeing exsiting classes should be done.

The only one that kind of bothered me was the todo around line 225 in mapogcfilter.c : the final result should give 2 valid classes set (and numclasses should be equal to 2). It should not happen where at this point we have more that 1 class.

Schpidi commented 11 years ago

This is an automated comment

This issue has been closed due to lack of activity. This doesn't mean the issue is invalid, it simply got no attention within the last year. Please reopen if still valid.