search

MapServer / MapServer-import

3 stars 2 forks source link

Do we still need 'isachild' member in styleObj? #2169

Open tbonfort opened 12 years ago

tbonfort commented 12 years ago

Reporter: dmorissette Date: 2007/07/23 - 16:31 While working on #302, I noticed the '''isachild''' member in the styleObj that doesn't seem to be used any more (or anyway its value doesn't seem to be used anywhere based on a quick grep):

#ifndef SWIG
  /* Whether the style is within a class MS_TRUE or MS_FALSE.
   * If true, then memory deallocation is handled by the class
   * if false, then memory deallocation must be handled by the
   * application.
   */
  int isachild;
#endif

Can we remove this member? Is it still used by any of the SWIG wrappers?

tbonfort commented 12 years ago

Author: sdlime Date: 2007/08/01 - 05:40 style.i still references that attribute. However, it only sets it and there is no code that relies on the value that I can find. So, I think it could be removed (style.i would need updating then).

Steve

tbonfort commented 12 years ago

Author: dmorissette Date: 2007/08/01 - 16:15 Sounds good, taking this ticket and removing isachild now.

tbonfort commented 12 years ago

Author: dmorissette Date: 2007/08/01 - 16:24 Done. styleObj.isachild member removed in 46d9dcc1e496c306026e29f500a490edbd09d852 (r6434) (will be in 5.0.0-beta2).

Schpidi commented 11 years ago

This is an automated comment

This issue has been closed due to lack of activity. This doesn't mean the issue is invalid, it simply got no attention within the last year. Please reopen if still valid.