MapServer / MapServer-import

3 stars 2 forks source link

MapScript docs for mapObj->setRotation() #702

Closed tbonfort closed 12 years ago

tbonfort commented 12 years ago

Reporter: dmorissette Date: 2004/05/31 - 17:35

I have written the following description in mapscript/php3/README for the PHP
mapObj method setRotation().

   boolean setRotation(double rotation_angle)
        Set map rotation angle. The map view rectangle (specified in 
        EXTENTS) will be rotated by the indicated angle in the counter-
        clockwise direction. Note that this implies the rendered map 
        will be rotated by the angle in the clockwise direction.
        Returns MS_TRUE/MS_FALSE (true on success, false on error?).

Frank: can you please confirm what the return value means?

Also the doc for the function should be added to the SWIG mapscript.txt
tbonfort commented 12 years ago

Author: fwarmerdam Date: 2004/05/31 - 19:31

I have fixed msMapComputeGeotransform() to return MS_FAILURE or MS_SUCCESS
and thus also msMapSetRotation(). 

Also, added setRotation() methods docs to mapscript.txt.
tbonfort commented 12 years ago

Author: dmorissette Date: 2004/06/01 - 20:16

Thanks. I have updated the PHP MapScript README file, and noticed a little typo
in the mapscript.txt:

setRotation(double rotation_angle) : rotation

I believe the return type should be 'int' and not 'rotation', right?  I have
committed that change to CVS as well.
tbonfort commented 12 years ago

Author: fwarmerdam Date: 2004/06/01 - 20:44

yes, of course you are right.
tbonfort commented 12 years ago

Author: sgillies@frii.com Date: 2004/06/01 - 20:45

Also, since our high level languages don't have a double type (because our
floats are doubles) let's do

setRotation(float rotation_angle) : int

at least in mapscript.txt.
tbonfort commented 12 years ago

Author: dmorissette Date: 2004/06/02 - 05:00

I changed double to float in mapscript.txt for setRotation()... and also for
queryByPoint()