Open tbonfort opened 12 years ago
Author: sgillies@frii.com Date: 2004/09/03 - 16:05
It is good to see some action on the C# front. I do not use the language
and do not have a .NET platform. This means that I will require patches to
fix this bug. I can merge the patches and make sure that they don't break
the other language interfaces.
Would you be able to provide patches? Are you familiar with using CVS?
1) These parameter names are bad for many reasons. I'll make a sweep through
the files and fix the obvious ones. Then you could try again and give me
some patches.
2) I think I just read about this bug on the swig list. Isn't using 1.3.19
the best solution for now?
3) There are a *lot* of poorly named structure members in mapserver. I'll
look and see how much work is involved in changing the string member.
Some questions for you, since I am unfamiliar with C#. Is "text" a reserved
word?
Author: sgillies@frii.com Date: 2004/09/03 - 17:40
OK, I just addressed part 1) in CVS HEAD and branch-4-2. All my unit tests
pass. Will await confirmation or a patch.
on 3 -- changing 'string' to 'labelstring' or such would involve edits to
5 or 6 files. Not too bad, but I won't start on it until I get confirmation
on part 1.
Author: sgillies@frii.com Date: 2004/09/05 - 17:48
yk, since I already finished the renaming before you submitted the file, I'm
going to reject your file. The inclusion of typemaps.i is now conditional,
as in your file. As a workaround for the labelCacheMemberObj, I am going to
hide this class from C# until bug 852 is fixed. It is not an essential part
of mapscript.
I am attaching a new mapscript.i file as a .tar.gz. Please test it and
confirm if it works.
Author: ykchoo@geozervice.com Date: 2004/09/06 - 09:22
Please note that patched mapscript.i 4.2.3-2 in BUG 848 fixes both C# and Java
compilation errors. Thanks again for the quick response.
Author: sgillies@frii.com Date: 2004/09/07 - 15:47
Y.K. -- don't close the bug prematurely, you should leave that up to the
engineer working on the bug (me).
Author: sgillies@frii.com Date: 2004/09/08 - 17:12
closed.
Reporter: ykchoo@geozervice.com Date: 2004/09/03 - 09:01