search

MapServer / mapcache

MapCache source code directory. Please submit pull requests to the 'main' branch.
https://mapserver.org/mapcache
Other
137 stars 96 forks source link

Add support for pcre2. #314

Closed sebastic closed 1 year ago

sebastic commented 1 year ago

This is my naive attempt to add support for PCRE2.

It builds successfully, but my C-fu is not very strong, so I'm not sure about the correctness.

@jmckenna can you review this?

jmckenna commented 1 year ago

thanks @sebastic I'll test this...

jmckenna commented 1 year ago

Thanks @sebastic works very well on Windows! (I also made some other minor changes to CMakeLists.txt in this PR to remove some warnings) I think we should merge this.

sebastic commented 1 year ago

I think we should merge this

Maybe rebase it first to not have such an ugly history?

jmckenna commented 1 year ago

ok I will try "rebase and merge" (I was initially going to "squash and merge" & remove my history)