MapStory / mapstory-meta

MapStory
http://mapstory.org
32 stars 16 forks source link

Time too specific when editing annotations #66

Closed dwins closed 12 years ago

dwins commented 12 years ago

When editing annotations, if you enter an imprecise value for the date the editor appears to fill in the gaps with the current time. Here the time was entered as just "1390" but echoed back as "11/21/1390" (added on 11/21/2011) https://skitch.com/alyssawright/gk8db/map-viewer-geonode

bartvde commented 12 years ago

Hmm apparently this is how Javascript handles dates:

Date.parseDate("1931", "Y")

yields:

Date {Tue Jan 06 1931 00:00:00 GMT+0100 (AMT)}

Need to see if there is way around this.

bartvde commented 12 years ago

I should have said how Ext handles it.

Plain javascript yields:

new Date("1931")

Date {Thu Jan 01 1931 01:00:00 GMT+0100 (AMT)}

bartvde commented 12 years ago

c ISO 8601 date Notes: Examples: 1) If unspecified, the month / day defaults to the current month / day, 1991 or the time defaults to midnight, while the timezone defaults to the 1992-10 or browser's timezone. If a time is specified, it must include both hours 1993-09-20 or and minutes. The "T" delimiter, seconds, milliseconds and timezone 1994-08-19T16:20+01:00 or are optional.

bartvde commented 12 years ago

dwins, just to confirm, when specifying 1930 you want it to be 01-01-1930?

dwins commented 12 years ago

Well, technically "1930" corresponds to a time range, [1930-01-01T00:00:00, 1931-01-01T00:00:00). In the absence of good interval support on the server though, using the start of the interval seems like the way to go. Btw, this ticket is from Alyssa's and my notes from the November demo, so she might have other thoughts on the issue. @awright ?

bartvde commented 12 years ago

Fixed with https://github.com/opengeo/gxp/commit/8f43392cc0f3e58910d3656a9c1eb303479092c7

Please reopen if something else was needed.