search

MapStory / story-tools

MIT License
8 stars 10 forks source link

ol3 marker size slightly off #52

Open ischneider opened 9 years ago

ischneider commented 9 years ago

@bartvde, totally minor but internally the canvas size for 'marks' (our builitin icons) is off - it doesn't account for the internal computation. This is a very minor issue.

See: https://github.com/MapStory/story-tools/blob/3af17b12d55fe4443ebcee48fe2e247ca4463b5d/lib/style/services/ol3StyleConverter.js#L24

And the same commit for adjustments in test expectations to account for the change. This commit uses the ol3 styles to render the mark/symbol drop-down in anticipation of adding more SVG support.

bartvde commented 9 years ago

ah right getting it now (gets another coffee ....) this makes sense.

bartvde commented 9 years ago

fixed with 3af17b12d55fe4443ebcee48fe2e247ca4463b5d

bartvde commented 9 years ago

@ischneider so is your intention to get radius updated /corrected for the stroke width as well?

ischneider commented 9 years ago

@bartvde - sorry for not being clear: 3af17b1 almost fixes it by using the size as a radius.

The stroke width is not available at that point of the code (or is only available w/ a debug ol3 build).

Again, it's not a major issue but I discovered it while trying to get the icons to display properly as the generated canvas size would not match my inputs.