MapStory / story-tools

MIT License
8 stars 10 forks source link

using natural breaks raises WPS error #89

Open bartvde opened 9 years ago

bartvde commented 9 years ago

point range created with the interval constructor must have min and max endpoints included

not sure yet what this means

Example request:

<wps:Execute xmlns:wps="http://www.opengis.net/wps/1.0.0" xmlns:xlink="http://www.w3.org/1999/xlink"
    xmlns:ows="http://www.opengis.net/ows/1.1" xmlns:wfs="http://www.opengis.net/wfs" service="WPS"
    version="1.0.0">
    <ows:Identifier>vec:FeatureClassStats</ows:Identifier>
    <wps:DataInputs>
        <wps:Input>
            <ows:Identifier>features</ows:Identifier>
            <wps:Reference xlink:href="http://geoserver/wfs" method="POST" mimeType="text/xml">
                <wps:Body>
                    <wfs:GetFeature service="WFS" version="1.1.0" outputFormat="GML2">
                        <wfs:Query xmlns:topp="http://www.openplans.org/topp" typeName="topp:states"
                        />
                    </wfs:GetFeature>
                </wps:Body>
            </wps:Reference>
        </wps:Input>
        <wps:Input>
            <ows:Identifier>attribute</ows:Identifier>
            <wps:Data>
                <wps:LiteralData>P_MALE</wps:LiteralData>
            </wps:Data>
        </wps:Input>
        <wps:Input>
            <ows:Identifier>classes</ows:Identifier>
            <wps:Data>
                <wps:LiteralData>5</wps:LiteralData>
            </wps:Data>
        </wps:Input>
        <wps:Input>
            <ows:Identifier>method</ows:Identifier>
            <wps:Data>
                <wps:LiteralData>NATURAL_BREAKS</wps:LiteralData>
            </wps:Data>
        </wps:Input>
        <wps:Input>
            <ows:Identifier>stats</ows:Identifier>
            <wps:Data>
                <wps:LiteralData>mean</wps:LiteralData>
            </wps:Data>
        </wps:Input>
    </wps:DataInputs>
    <wps:ResponseForm>
        <wps:RawDataOutput>
            <ows:Identifier>results</ows:Identifier>
        </wps:RawDataOutput>
    </wps:ResponseForm>
</wps:Execute>
bartvde commented 9 years ago

@ischneider I don't see any reference to that message when comparing Justin's branches, do you think the error is raised by existing code?

bartvde commented 9 years ago

the other two methods work okay, but this one is refusing

ischneider commented 9 years ago

I'm not seeing this issue but I rebased Justin's branch onto master and am running GeoServer on a maven build so perhaps this was dealt with?

I did find an issue with EQUAL_INTERVAL though... time for integration tests? :smile:

bartvde commented 9 years ago

could it be data dependent?

bartvde commented 9 years ago

What issue did you see with EQUAL_INTERVAL? I did get some errors depending on the column data type IIRC

bartvde commented 9 years ago

Is it easy enough to get me a war file that is similar to yours?

bartvde commented 9 years ago

Wrt integration tests, how would we setup the GeoServer required for them?

ischneider commented 9 years ago

could it be data dependent?

Yes but nothing obvious (used area, IIRC)

What issue did you see with EQUAL_INTERVAL? I did get some errors depending on the column data type IIRC

NullPointerException - perhaps null?

Is it easy enough to get me a war file that is similar to yours?

I had to modify the spring context for things to work in master but shouldn't be too difficult. My upload bandwidth is poor and kills everything else so I'll get a build going on the dev machine.

Wrt integration tests, how would we setup the GeoServer required for them?

My thought is to use the 'release' data directory for whatever build we end up using. The integration tests can be run separate of the others to not bog stuff down.