search

MapWindow / MapWinGIS

MapWinGIS.ocx is a FREE and OPEN SOURCE C++ based geographic information system programming ActiveX Control and application programmer interface (API) that can be added to a Windows Form in Visual Basic, C#, Delphi, or other languages that support ActiveX, providing your app with a map. Go to our forum for questions and help:
https://mapwindow.discourse.group/
Mozilla Public License 2.0
270 stars 134 forks source link

CShapefileDrawer sfDrawer in Map_Drawing.cpp missing a param [zoom]. #215

Closed ningfc closed 2 years ago

ningfc commented 2 years ago

I Found a Param missing problem in MapWinGIS code, at Map_Drawing.cpp CMapView::DrawLayers CShapefileDrawer sfDrawer(graphics, &_extents, _pixelPerProjectionX, _pixelPerProjectionY, &_collisionList, this->GetCurrentScale(), true); This constructer miss a param zoom. CShapefileDrawer drawer(g, &_extents, _pixelPerProjectionX, _pixelPerProjectionY, &_collisionList, GetCurrentScale(), GetCurrentZoom(), true); This is used at other place in MapWinGIS Code, ti's correct.

jerryfaust commented 2 years ago

Hello @ningfc

Yes, you are correct. Looks like one of the developers added a new parameter to the constructor, but didn't catch all of the related calls. And the compiler didn't catch it due to the last parameter being optional.

Thank you. I'll try to get this fix incorporated.

Regards, Jerry.

jerryfaust commented 2 years ago

Fixed in Jira issue MWGIS-239.

ningfc commented 2 years ago

Fixed in Jira issue MWGIS-239.

OK, Thank you! I'll close this issue.