search

MapWindow / MapWindow5

MW5 is a desktop GIS which is extendable using the plug-in architecture. It is using the MapWinGIS mapping control and is created from scratch in 2015 using new technologies like MEF and Dependency Injection making it small in size, robust and fast.
288 stars 100 forks source link

Adding segment/vertex snapping options to the shape editor #39

Closed mathijs-dumon closed 4 years ago

mathijs-dumon commented 5 years ago

Should be merge only if the corresponding PR from MapWinGIS has been accepted (https://github.com/MapWindow/MapWinGIS/pull/132)

mathijs-dumon commented 5 years ago

@pmeems Is there anything I still need to do for this?

pmeems commented 5 years ago

@mathijs-dumon Did you verify it is still working as expected with the latest dev code of MapWinGIS. If so I will merge your changes.

pmeems commented 5 years ago

@mathijs-dumon I did a review of your pull request and it has many more changes and improvements than just 'Adding segment/vertex snapping options to the shape editor'. That is fine but to track changes I want to ask you if you can make a list of your changes so I can add it to our issue tracker and then it will end up in the release notes.

mathijs-dumon commented 5 years ago

Ah shoot, I actually wanted to make seperate pull requests for these. Didn't realize this pr was on the develop branch. My bad. I'll do as you suggest and document the changes with the relevant commits asap.

mathijs-dumon commented 4 years ago

closing as this is no longer relevant