Maplespe / DWMBlurGlass

Add custom effect to global system title bar, support win10 and win11.
GNU Lesser General Public License v3.0
1.89k stars 86 forks source link

[feature request] re-implementation of glow-related dwm functions #23

Open not-nullptr opened 8 months ago

not-nullptr commented 8 months ago

hello! just to preface, i do realise that this is entirely out of the scope of this project. with that being said, nobody else has done it and i think the existence of the "windows 7 style buttons" option justifies this issue. with that being said, the re-implementation of button glow on hover/press would be a really cool feature. the first screenshot is on windows 7 sp1 and the second screenshot is windows 10 22h2 using dwmblurglass:

image image

i think this falls within the same sort of bounds as #5 because the glow effects are included in the third party theme installed on the computer. thank you for your time ! :]

Maplespe commented 8 months ago

Microsoft should have removed the related functionality from dwm, there is no ready way to do it. Re-implementing it could be very difficult.

not-nullptr commented 8 months ago

i'm not very experienced with lower level programming so i wouldn't be of much help, but as far as im aware, the effect is really only just reading the glow effect from the atlas (dwm doesnt generate it, its a bitmap) and then displaying it. unless that's difficult to do, the hardest part would probably be the fading behaviour

image

funn-hue commented 8 months ago

i'm not very experienced with lower level programming so i wouldn't be of much help, but as far as im aware, the effect is really only just reading the glow effect from the atlas (dwm doesnt generate it, its a bitmap) and then displaying it. unless that's difficult to do, the hardest part would probably be the fading behaviour

image

correct, it seems to read that from the atlas, i might create a windows 8.1 vm rn and check if it wasnt deleted from dwm, because i know that the 8.1 msstyle still has the class for the close button glow

not-nullptr commented 8 months ago

any updates on this? with 2.0.0 bringing the most accurate aero shader (even better than glass8 lol) to windows 10, it'd be a shame to see something like button glow be ignored

Maplespe commented 8 months ago

Honestly, in itself, the original purpose of our program was to implement the background effect only, any other features responsible would have been out of our scope of work, and the resizing of win7 buttons was just out of convenience. Our program is not working exclusively for Win7 effects only, aero is just a part of it, we are also responsible for Acrylic, Mica and other Fluent Design. We don't have so much energy to maintain so many requests and features, if everyone makes a request we have to fulfill it immediately then I don't think I need to open source myself anymore, we are doing unpaid work and are not obligated to necessarily fulfill certain content. I hope you don't get the wrong idea, this program was not created to restore all the features of Win7 1:1. We have done too much work on it, and not replying doesn't mean we haven't thought about it, just not at the right time. I hope you can understand and stay patient, thanks.

not-nullptr commented 8 months ago

leaving an issue stale gives the impression that it hasn't been read. ofc this project isn't for anything more than blur, if u don't want to re-add glow support from the msstyles that's up to you

Maplespe commented 7 months ago

What theme are you using? I didn't find a Part or Class for the glow button in win10's msstyle. In win7 msstyle has the class CLOSEBUTTONGLOW(Class:202,Part11). But I don't find that class in win10's msstyle, it seems to have been completely removed from msstyle.

not-nullptr commented 7 months ago

What theme are you using? I didn't find a Part or Class for the glow button in win10's msstyle. In win7 msstyle has the class CLOSEBUTTONGLOW(Class:202,Part11). But I don't find that class in win10's msstyle, it seems to have been completely removed from msstyle.

yup, windows 10 had no glow, which is why the support was dropped from dwm

Olive6841 commented 7 months ago

What theme are you using? I didn't find a Part or Class for the glow button in win10's msstyle. In win7 msstyle has the class CLOSEBUTTONGLOW(Class:202,Part11). But I don't find that class in win10's msstyle, it seems to have been completely removed from msstyle.

yup, windows 10 had no glow, which is why the support was dropped from dwm

What about in the windows setup 1st phase? The glow still works on those buttons

funn-hue commented 7 months ago

What theme are you using? I didn't find a Part or Class for the glow button in win10's msstyle. In win7 msstyle has the class CLOSEBUTTONGLOW(Class:202,Part11). But I don't find that class in win10's msstyle, it seems to have been completely removed from msstyle.

yup, windows 10 had no glow, which is why the support was dropped from dwm

What about in the windows setup 1st phase? The glow still works on those buttons

what

jonm58 commented 7 months ago

What theme are you using? I didn't find a Part or Class for the glow button in win10's msstyle. In win7 msstyle has the class CLOSEBUTTONGLOW(Class:202,Part11). But I don't find that class in win10's msstyle, it seems to have been completely removed from msstyle.

yup, windows 10 had no glow, which is why the support was dropped from dwm

What about in the windows setup 1st phase? The glow still works on those buttons

?

funn-hue commented 7 months ago

What theme are you using? I didn't find a Part or Class for the glow button in win10's msstyle. In win7 msstyle has the class CLOSEBUTTONGLOW(Class:202,Part11). But I don't find that class in win10's msstyle, it seems to have been completely removed from msstyle.

yup, windows 10 had no glow, which is why the support was dropped from dwm

What about in the windows setup 1st phase? The glow still works on those buttons

Oh i get it, setup does use the win 7 like close button, but it's not related to dwm, the whole setup ui is made from shitty broken bitmaps that are begging to be taken out of their misery

Maplespe commented 5 months ago

I've posted a test version implementing this feature in #282, so you can try it out.

not-nullptr commented 5 months ago

WE'RE SO BACK

Xamtastic1 commented 5 months ago

Are you guys remaking aero glass for windows 11 or something If so I would do anything to have it

Maplespe commented 5 months ago

Win11 works with the same features that Win10 currently has.