MapoMagpie / eh-view-enhance

Manga Viewer + Downloader, Focus on experience and low load on the site. Support: e-hentai.org | exhentai.org | pixiv.net | 18comic.vip | nhentai.net | hitomi.la | rule34.xxx | danbooru.donmai.us | gelbooru.com | twitter.com
MIT License
264 stars 8 forks source link

Unable to function properly on MacOS and Safari browser. #43

Closed DouiKo closed 4 months ago

DouiKo commented 5 months ago

Describe the bug Unable to function when using UserScripts as a script loader, specifically manifested by the lack of a browsing mode icon in the bottom left corner.

Can function properly when using Stay as a script loader. Since the Userscripts plugin is free and open source, this is the choice of most macOS users. Hope to add support for Userscripts.

I have not used JavaScripts before. If you could point out where the issue lies in the code, I hope I can assist you in debugging.

Browser And Version Browser: Safari 17.0 (19616.1.27.211.1) Script loader application: UserScripts

Log

image
MapoMagpie commented 5 months ago

It looks like GM_getValue is undefined, but I see that UserScripts already implements these APIs: https://github.com/quoid/userscripts?tab=readme-ov-file#api I will try to test this issue. Now, you can try reinstall from here: https://github.com/MapoMagpie/eh-view-enhance/raw/gm_api/eh-view-enhance.user.js

DouiKo commented 5 months ago

I tested https://github.com/MapoMagpie/eh-view-enhance/raw/gm_api/eh-view-enhance.user.js on safari, but it seems to still not work. The current error is as follows:

image

After searching just now, I found a workaround and hope this PR can offer some help. Thank you for your work.

MapoMagpie commented 4 months ago

fb08fbe6050b48a8da4f91c3c5a19c8316456bc3