search

MapofLife / MOL

Integrating information about species distributions in an effort to support global understanding of the world's biodiversity.
http://mol.org
BSD 3-Clause "New" or "Revised" License
25 stars 2 forks source link

Feature/species list tool #112

Closed jmalczyk closed 12 years ago

jmalczyk commented 12 years ago

Adds EOL buttons that link to species pages on EOL to the species list tool, and wiki buttons just to be consistent.

eightysteele commented 12 years ago

There are some formatting problems in mol.map.query.js. Lines 100, 133, 213, 232, and more are missing semicolons. The stats variable on line 236 is undeclared which makes it global (so just need to declare it as a var at top of function). Please double check all indents as well. They should be 4 spaces (no tabs). I'm seeing a lot of extra indentations.

eightysteele commented 12 years ago

@jmalczyk looking better dude. I fixed a bunch of additional formatting stuff. Also added some TODOs. Big one is the if statement on line 210 which is a complete beast. That thing needs to be broken down a bit into a few different functions. Right now it's too hard to reason about. At the least, add some docs in there and sub an issue to fix that up.

jmalczyk commented 12 years ago

Added issue #114