search

MapofLife / datasets

A datasets list and information view for Map of Life
https://mol.org/datasets/
MIT License
1 stars 2 forks source link

Fix scrolling #38

Open rafelafrance opened 8 years ago

rafelafrance commented 8 years ago

Have the facets and map/list areas scroll independently

jmalczyk commented 8 years ago

This is better. I like that the facets stay in view. What do you think @funkycoda? Was originally thinking of using display:fixed on the sidebar content to keep it in view as the rest of the page scrolled, so the header could scroll out of view, but this is probably fine.

On Thu, Jul 28, 2016 at 4:07 PM, rafe notifications@github.com wrote:

Assigned #38 https://github.com/MapofLife/datasets/issues/38 to @jmalczyk https://github.com/jmalczyk.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MapofLife/datasets/issues/38#event-738371156, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMO0wqER8h7bjiGV9quq2CzSSGTfzjMks5qaQv8gaJpZM4JXaMU .

funkycoda commented 8 years ago

I agree. I do like this already, but future version should scroll the header. There isn't too much content within header to let it NOT scroll. This would mean it would have the same functionality as the dataset info page too where the header scrolls.

E.g: http://mol.org/datasets/fe4b9fd2-7da6-46b8-8bef-754044461210

jmalczyk commented 8 years ago

yeah, maybe while we are here, see if you can get it so everything scrolls as before, but the sidebar container sticks to the top when the header is out of view. There may be a bootstrap class for this.

On Thu, Jul 28, 2016 at 4:37 PM, Ajay Ranipeta notifications@github.com wrote:

I agree. I do like this already, but future version should scroll the header. There isn't too much content within header to let it NOT scroll. This would mean it would have the same functionality as the dataset info page too where the header scrolls.

E.g: http://mol.org/datasets/fe4b9fd2-7da6-46b8-8bef-754044461210

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MapofLife/datasets/issues/38#issuecomment-236017691, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMO08V0pjhUm-ffvTOShQmXAVVDLAyjks5qaRMRgaJpZM4JXaMU .

funkycoda commented 8 years ago

Yeah, it'd be great to see if we can get this affect: http://getbootstrap.com/javascript/#affix Can't see it available on Angular-Bootstrap

Don't think this is super urgent though. Something for a wish list, perhaps.

jmalczyk commented 8 years ago

If it involves significant jquery-based bootstrap let's not touch it right now.

On Thu, Jul 28, 2016 at 4:59 PM, Ajay Ranipeta notifications@github.com wrote:

Yeah, it'd be great to see if we can get this affect: http://getbootstrap.com/javascript/#affix Can't see it available on Angular-Bootstrap http://angular-ui.github.io/bootstrap/

Don't think this is super urgent though. Something for a wish list, perhaps.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MapofLife/datasets/issues/38#issuecomment-236023428, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMO00kYKJtJwBQQ6ZKbiDhd_8DMNxVlks5qaRgpgaJpZM4JXaMU .