[QMS-547] Fixed: QMS freezes on zoom when activating multi-layered on… - Githubissues

Maproom / qmapshack

Consumer grade GIS software

GNU General Public License v3.0

287 stars 64 forks source link

[QMS-547] Fixed: QMS freezes on zoom when activating multi-layered on… #639

Closed kiozen closed 1 year ago

kiozen commented 1 year ago

…line maps

What is the linked issue for this pull request:

QMS-#547

What you have done:

Instead of locking the mutex in the override methods of IDrawObject::getLayers(), try to lock the mutex and abort after 100ms.

Steps to perform a simple smoke test:

Activate a TMS map with multiple layers, e.g. google.tms
Wildly move and zoom the map. --> must not fail

Does the code comply to the coding rules and naming conventions Coding Guidelines:

[x] yes

Is every user facing string in a tr() macro?

[x] yes

Did you add the ticket number and title into the changelog? Keep the numeric order in each release block.

[x] yes, I didn't forget to change changelog.txt

mitxel-m commented 1 year ago

A bit late, but just to reconfirm:

testing google.tms with previous QMS 1.17.0 -> freezes randomly.
testing google.tms after this last commit ada4ed2 -> it runs OK for me.

Linux MINT21 / QT 5.15.3 / GDAL 3.4.1 / PROJ 8.2.1