Maproom / qmapshack

Consumer grade GIS software
GNU General Public License v3.0
271 stars 63 forks source link

Changes for GISInternals-based Windows version #646

Closed wthaem closed 6 months ago

wthaem commented 7 months ago

What is the linked issue for this pull request:

QMS-#

What you have done:

Changed qunsetenv("GDAL_DRIVER_PATH"); ==> // qunsetenv("GDAL_DRIVER_PATH"); in CAppSetupWin.cpp to enable support for MBTiles/ECW/... maps

Steps to perform a simple smoke test:

  1. Open whatever
  2. Click here

Does the code comply to the coding rules and naming conventions Coding Guidelines:

Is every user facing string in a tr() macro?

Did you add the ticket number and title into the changelog? Keep the numeric order in each release block.

wthaem commented 7 months ago

@kiozen: My indention was to get this PR in my new fork but it appeared in the main repo. Therefore, the description is incomplete and not linked to an issue. Sorry for this. Please, decide if the 2 changes made should go into the main repo, too. If not, please, delete this PR somehow.

kiozen commented 7 months ago

Let's see how this evolves and decide later if we want to merge it or keep the GIS Internals stuff on the fork

kiozen commented 6 months ago

@wthaem How do we want to proceed? I am tempted to merge the changes to dev.

[ ] Do it [ ] Wait for more [ ] Forget about it

Whatever you like.

wthaem commented 6 months ago

@kiozen: Do it (at least for Windows OS - no clue about other OS), but have a look at Mitxel's suggestion!

kiozen commented 6 months ago

I merge this for now to get it into the release.