add event panel with misaligned fields

okvittem commented 7 years ago

The Map selector appears on the next line after the 'Map' header in the Add event panel and the following lines is accordingly off by one line.

This is latest Firefox on Linux 55.0.2. The alignment is fine in Chrome. RG2 is the latest from github.

dg0yt commented 6 years ago

Still an issue in Firefox 61/Linux. Here, the club field is the first one which is misplaced. I didn't notice until I came to the event date field.

dg0yt commented 6 years ago

<div id="rg2-manager-map-select">
  <span>Map:<select class="pushright manage-input" id="rg2-map-selected"></select></span>
</div>

There are two issues here:

There seems to be an inappropriate mix of inline and block features here: label and input field are put in a span (inline), but the input field is marked float:right (via CSS class pushright) -- which is a block feature AFAIU.
There is no clearing of the floats. If they wouldn't be more than 50% wide, they could as well end up placed side by side. This issue can be solved in the rg2[...].css file by implementing a clearfix solution as used in Bootstrap:
```
#rg2-manage-create > div::after {
display: block;
content: "";
clear: both;
}
```

okvittem commented 6 years ago

On 17. juli 2018 08:32, Kai Pastor wrote:

|
Map:
|

There are two issues here:

There seems to be an inappropriate mix of inline and block features here: label and input field are put in a |span| (inline), but the input field is marked |float:right| (via CSS class |pushright|) -- which is a block feature AFAIU.

There is no clearing of the floats. If they wouldn't be more than 50% wide, they could as well end up placed side by side. This issue can be solved in the rg2 .css file by implementing a clearfix solution as used in Bootstrap https://getbootstrap.com/docs/4.1/utilities/clearfix/: |#rg2-manage-create > div::after { display: block; content: ""; clear: both; }|

Hi, Thanks for fixing up : |I appended this to css/rg2.css

it looks OK in Chromium and Vivaldi with Map selector being in line with the Map: lead text, but not in Firefox.

cheers Olav |

* ||

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Maprunner/rg2/issues/399#issuecomment-405474802, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8zNHmO8Lx71lmzjvzQOjMzBzs7fBYAks5uHYT3gaJpZM4PpsWF.

dg0yt commented 6 years ago

For an installed rg2, you need to modify rg2-1.4.8.min.css (or whatever version is loaded in the version you installed).

Maprunner / rg2

add event panel with misaligned fields #399