search

Maprunner / rg2

Updated user interface for Routegadget
MIT License
36 stars 20 forks source link

NaN in statistics results table #452

Closed Maprunner closed 3 years ago

Maprunner commented 4 years ago

See Hankley Common Seems to be associated with the odd results file they used with "missing" missed controls. Root cause is that people who mispunched don't have 0 splits for missing controls, so the splits arrays are too short for some people.

Maprunner commented 4 years ago

Problem is incorrect handling of status: 

<SplitTime status="Missing">
  <ControlCode>201</ControlCode>
</SplitTime>

This should be imported rather than ignored. Change is in resultparseriovv3.js, which has a nice comment explaining exactly why I got it wrong.

    // only possible attributes are "Missing" and "Additional" so
    // if splitlist has attributes it is invalid and needs to be ignored
    if (splitlist[x].attributes.length === 0) {
Maprunner commented 3 years ago

Above changes have fixed it.