search

Maps4HTML / HTML-Map-Element-UseCases-Requirements

Use cases and requirements for Maps on the Web
https://maps4html.org/HTML-Map-Element-UseCases-Requirements/
Other
22 stars 12 forks source link

Client api capabilities #196

Closed NickFitz closed 4 years ago

NickFitz commented 4 years ago

There are more updates to the API capabilities on the way, but I wanted to get these across to invite feedback. I’m keeping them in their own branch so they don’t get mixed up with changes to the examples.

NickFitz commented 4 years ago

However, if you're not going to have time to work on this soon, we could merge the PR & remind ourselves to work on it with a comment in that capability's issue discussion page.

I have time, and I’d like to continue with these capabilities for now - I seem to have got bogged down with a lot of notes and some rough drafts, but I’d like to get more of that into the document now so it can be discussed/changed/discarded as appropriate, otherwise there’s a danger I’ll get lost in the weeds. So it’s probably best to leave this PR open for now.

(I’ve also got a chunk of work done on the d3-geo examples, which needs a bit more polishing yet but which I’ll include in a separate PR once it’s ready.)

AmeliaBR commented 4 years ago

Hi @NickFitz,

Have you got any updates on this PR, or should we go back to the “merge for now” option?

AmeliaBR commented 4 years ago

Adding to the record of the discussion what I said to Nick in our 1-on-1 call:

Definitely consolidate some of the capabilities if it looks like the notes are going to be redundant. The prose about existing implementations — and eventually, about the requirements — can include short lists of the specific sub-capabilities (e.g., which exact events you can listen for).

NickFitz commented 4 years ago

Adding to the record of the discussion what I said to Nick in our 1-on-1 call:

Definitely consolidate some of the capabilities if it looks like the notes are going to be redundant.

I’ve quickly consolidated/removed the capabilities we discussed so you can merge this PR when ready (assuming no more obvious spelling mistakes turn up).

Malvoz commented 4 years ago

Closes #62, closes #64, closes #70, closes #71 & closes #73.

As expected, closing keywords only work in commit messages and PR descriptions, leaving this as a reminder to close those out when this is merged (issue 63 and 69 will need edits to reflect these changes as well).

AmeliaBR commented 4 years ago

Again, apologies for not seeing/reviewing the additional edits when they came in last week. Merging now, so you can focus on filling in the newly consolidated sections.

Thanks @Malvoz for pulling up the references to the discussion pages, I'll go through and tidy up those.