search

Maps4HTML / HTML-Map-Element-UseCases-Requirements

Use cases and requirements for Maps on the Web
https://maps4html.org/HTML-Map-Element-UseCases-Requirements/
Other
22 stars 12 forks source link

Migrate from Travis CI to Github Actions #245

Closed nchan0154 closed 3 years ago

nchan0154 commented 3 years ago

I think I've addressed this with a Github Action! It would be good to merge some of the small lingering PRs to make sure this is functioning as desired before we remove Travis and close this one out. :)

prushforth commented 3 years ago

Huh too bad I disabled travis in January. Sorry I didn't realize you had this job running. Does the action do what you want? Thanks for taking care of it!

AmeliaBR commented 3 years ago

OK, I merged a couple of @Malvoz's pending PR fixes (which should have been merged long ago!) & it looks like the builds got pushed to Github Pages fine.

The Github Actions page is a little confusing, though. The table has a column for the status of each run, but nothing is showing as success (or any other status). Maybe there's an extra line in the YAML file for setting that value? https://github.com/Maps4HTML/HTML-Map-Element-UseCases-Requirements/actions/workflows/deploy.yml

Either way, it's probably safe to remove the Travis YAML now.

nchan0154 commented 3 years ago

Hmm, from what I can tell, the status select seems to be a filter, not a column header, the way to tell the status is via the check/cross icon next to the title. Certainly a bit of confusing UI there. Anyway, I've removed the Travis file, so we can probably close this one out!

AmeliaBR commented 3 years ago

Ah, you're right. Similar to the filters on an issue list.

I'm not sure why my brain didn't notice the checkmarks yesterday when I was trying to figure out if the builds had completed successfully, but anyway, glad to have someone else looking at it.