Test and Implement Leaflet 1.9.x*

[prushforth]

Currently, there are a few issues I see when running web-map-custom-element under Leaflet 1.8.0.beta 3

• [ ] get tests running
• [ ] provide feedback to Leaflet committers
• [ ] other - please comment

I tested the experiments with 1.8.0 beta 3, and it seems to work pretty well. I noticed a couple of things:

• layer control context menu no longer available / replaced by browser context menu
• after following a map-a link, the mouse pointer is stuck in the dragging state until released by another event
• unable to distinguish if tests are broken because test infrastructure isn't great or if the upgraded API causes breakage. Only a few tests (16) were broken, out of ~300.

[Malvoz]

• [ ] provide feedback to Leaflet committers

Here: https://github.com/Leaflet/Leaflet/discussions/8044.

[Malvoz]

With Leaflet 1.8.0 (or later):

• [ ] For the same reasons we decided not to go through with https://github.com/Maps4HTML/Web-Map-Custom-Element/issues/482, it's perhaps desirable to disable Leaflet's new feature autoPanOnFocus, which is enabled by default. Though atm I'm unsure if it even affects markers in this component.
• [ ] May want to set .leaflet-container { outline: 0 } due to https://github.com/Leaflet/Leaflet/pull/7996, since we have mapml-outline.

we should be able to remove:

• [ ] The .leaflet-active styles. (due to https://github.com/Leaflet/Leaflet/issues/7499)
• [ ] The .leaflet-popup-tip-container styles. (due to https://github.com/Leaflet/Leaflet/pull/7920)
• [ ] The font-size adjustments. (due to https://github.com/Leaflet/Leaflet/pull/8057)
• [ ] The print styles. (due to https://github.com/Leaflet/Leaflet/pull/7851)

---

And as a reminder to myself: the following in https://github.com/Maps4HTML/Web-Map-Custom-Element/issues/247 have been fixed:

Map component

• [ ] Should have resizable text (relative font-size units).

Zoom controls

• [ ] Characters + and - should be explicitly hidden from ATs.

• [ ] Should convey the disabled state to ATs when min/max zoom has been reached.

Layer control

• [ ] Should have role="button".

Popups

• [ ] Popup's Close button should have an accessible name and role="button".

• [ ] Character × in the popup's Close button should be explicitly hidden from ATs.

Attribution

• [ ] Should have resizable text (relative font-size units).

• [ ] The vertical lines (separators) should be aria-hidden="true".

[Malvoz]

@prushforth I don't think it's too long until the release of v1.9.0, FYI.

[Malvoz]

Leaflet v1.9.1 has been released! 🙂

Blog post: https://leafletjs.com/2022/09/21/leaflet-1.9.0.html

[prushforth]

Linking a few other issues to revisit once this task is done, to see if upstream changes have helped or resolved them.

• 19