search

Maps4HTML / web-map-doc

Documentation for Web-Map-Custom-Element https://maps4html.org/web-map-doc/
4 stars 10 forks source link

Code editor needs styling suitable for dark mode #66

Closed Malvoz closed 2 years ago

Malvoz commented 2 years ago

The new code editor has fixed light theme colors, there should also be styles for dark mode.

I.e. @media (prefers-color-scheme: dark) { /* dark theme colors */ }

/cc @AliyanH

Malvoz commented 2 years ago

side note: styles are duplicated in the HTML files in https://github.com/Maps4HTML/web-map-doc/tree/main/static/demo:

https://github.com/Maps4HTML/web-map-doc/blob/235b2335ac8034e58a6caa1ceb10df99e633c3f9/static/demo/extent-demo.html#L19-L78

https://github.com/Maps4HTML/web-map-doc/blob/235b2335ac8034e58a6caa1ceb10df99e633c3f9/static/demo/layer-demo.html#L19-L78

https://github.com/Maps4HTML/web-map-doc/blob/235b2335ac8034e58a6caa1ceb10df99e633c3f9/static/demo/mapml-viewer-demo.html#L19-L78

instead there could be a /code-editor.css file that contains these styles which the iframes can fetch through <link rel="stylesheet">, so that style changes only need to happen in one place. 🙂

AliyanH commented 2 years ago

Thanks Robert, Just came across this issue. Will be updated soon!

Malvoz commented 2 years ago

Fixed in https://github.com/Maps4HTML/web-map-doc/pull/85.