Open jankoci91 opened 1 year ago
Any exception stack trace?
There is no exception I'm aware of. Just null instead of "A" as result.
@jankoci91 Which NuGet package version are you using?
7.3.0 Sorry for missing info.
@jankoci91 Can you try the latest prerelease package please?
Done. Same result. Null instead of "A".
Hello, This is another type of bug #537 . Struct is detected as Record in https://github.com/MapsterMapper/Mapster/blob/04ac871b55828c3909b6cee4764e6fab40db3983/src/Mapster/Utils/ReflectionUtils.cs#L161
Thank you @jankoci91 and @DocSvartz. I ran a git bisect session using the test posted by @jankoci91 above, and ended up with https://github.com/MapsterMapper/Mapster/commit/773f64adac3925878c966990ef26d49290c9ba2a as the supposed culprit. Still trying to piece this together, but now we know which commit that introduced the problem that causes this test to fail.
@DocSvartz I think you're spot on. IsRecordType() is detecting types as record when it should not.
@andrerav I managed to make a partial fix. It seems that problems with collections #430 and modification by an Object of type #524 have a different reason for bug. This bug hit Fork and Clone config. There, too, instances are not created transparently. But based on tests, this behavior is legitimate.
Hi! Am I right that failing assert in this test means bug?
In version 6.5.1 it works fine.