Maptio / maptio

http://www.maptio.com
Other
24 stars 5 forks source link

When a person is removed from an organisation they aren't removed from maps #809

Open rgoj opened 1 year ago

rgoj commented 1 year ago

Problem

When a person is removed from an organisation they aren't removed from maps.

Reported here: https://app.intercom.com/a/inbox/q3x5lnhp/inbox/shared/all/conversation/106323200009977?view=List

Instructions for reproducing

Please describe steps we'll need to take to reproduce the problem you're seeing, e.g.

  1. Go to a map and add someone to a circle
  2. Go to Settings
  3. Delete the member of the organisation that you previously added to a circle
  4. Go back to the map...
  5. ...and see the person still in the cricle

Expected behavior

The person should've been removed from all circles.

Additional context

I'm not entirely sure, but I feel like this used to work, it's certainly behaviour I'd have expected. I can't find the code in any of the old versions, can't see where this could have broken down, but I it's likely I missed something when refactoring some bits of code that removed people from datasets on loading the datasets. Either way, the best fix would be to traverse and make changes to the datasets at the time the person is removed from the team, otherwise we're bound to run into these issues again.

rgoj commented 1 year ago

~We've discussed this on Slack and it seems that we've never had this - so removing the "bug" label and adding an "enhancement" one!~

Um, changing the labels back again, I'm not sure what my reasoning here was - just because the bug is very, very old, doesn't make it "not a bug" - this is clearly a bug not an enhancement!

rgoj commented 1 year ago

Raised again today (well, actually on 3 March): https://app.intercom.com/a/inbox/q3x5lnhp/inbox/shared/all/conversation/106323200010250?view=List

rgoj commented 1 year ago

And raised again (actually, it was raised back in August, and the customer just asked again whether we haven't fixed this because it is "quite annooying"): https://app.intercom.com/a/inbox/q3x5lnhp/inbox/conversation/106323200013177