Maptio / maptio

http://www.maptio.com
Other
23 stars 4 forks source link

Update Dockerfile #863

Closed VincentSC closed 5 months ago

VincentSC commented 5 months ago

Update nodejs-version to avoid npm WARN EBADENGINE Unsupported engine

Description

When installing using Dockerfile, it shows a lot of warning due to an old version of NodeJS:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'maptio@2.0.0',
npm WARN EBADENGINE   required: { node: '16.14.0', npm: '8.3.1' },
npm WARN EBADENGINE   current: { node: 'v16.4.0', npm: '7.18.1' }
npm WARN EBADENGINE }
...

This always needs to be in line with https://github.com/Maptio/maptio/blob/94243800ca09f2f18ac881c77663d3c0c33198de/package.json#L6 (!!!)

Testing

Run docker-compose up -d --build again, and then it builds.

rgoj commented 5 months ago

Thank you, @VincentSC, much appreciated!

How have you found using Docker with Maptio? I don't use Docker for Maptio myself, the Dockerfile was a recent contribution, which we incorporated, but aren't using for development nor staging/production yet. Would be great to know if it's worked well for you (with all the obvious caveats from #811 so maybe just the Docker bit is a mute point!).

Thank you again for contributing!

VincentSC commented 5 months ago

Ok, I'll share my changes of docker-compose and docker when I managed to get it going.

rgoj commented 5 months ago

Ok, I'll share my changes of docker-compose and docker when I managed to get it going.

That'd be super cool, thank you! 🙏🏻