[BUG] Faces don't update for players with short UID

Maradonna90 / NewGAN-Manager

A tool to generate and manage xml configs for the Newgen Facepack.

GNU General Public License v3.0

174 stars 34 forks source link

[BUG] Faces don't update for players with short UID #104

Closed twointum closed 2 years ago

twointum commented 2 years ago

Describe the bug https://imgur.com/upzRIv5 These guys didn't get a face!

To Reproduce Steps to reproduce the behavior: Try to add face to these two guys

Expected behavior Those guys to have a face

Desktop (please complete the following information): WIN10

I believe the xml parser is only looking for 7 digit ids and up. Not sure though.

Ayal1 commented 2 years ago

Not bug, that is intended behavior for now

Maradonna90 commented 2 years ago

works as intended so far. The only reason to allow <= 10 digits IDs is for fake players. But for now I like to avoid going lower than seven, because:

1) A super small minority is using the 'fake player' option 2) people might unintentionally overwrite 'real player' faces (although this can be fixed by smart subfolder naming in graphics