Wrong faces applied to players [BUG]

[Gold10bucket]

Hello guys,

Hope you're well!

I'm checking if I could have some assistance regarding players being assigned the wrong ethnicity. For example, all South Korean have African faces.

Thanks a lot for your help!

NewGanIssue.zip

[AngelsMari]

Hi there!

I don't know if this helps, I checked in the code files, in the mapper.py file (https://github.com/Maradonna90/NewGAN-Manager/blob/master/src/mapper.py), for all ethnicities in 1 almost it replaces with South American, for example if the ethnicity is Scandinavian in n1_ethnic or n2_ethnic then it will look for the image in South American.

I hope this helps!

[Gold10bucket]

Hi @AngelsMari Thanks a lot for checking and taking time to look into it, I have replaced in the mapper file South American to the corresponding ethnicity. Some of them seems to be fixes but still has some issues of some players with the wrong face., for example still have Asian players mapped to the African faces.

[AngelsMari]

I found a few things by looking at an RTF file:

2002164433 | JPN | Atsushi Echigo | St. Gallen | 3 | 16 | 10 | 2002205146 | JPN | Yûan Kojima | Shonan Bellmare | | 2 | 16 | 10 |

The player[3], if I've understood the code correctly, is equivalent to 3 for the first and 2 for the second, and it seems that these cases are not considered. I don't know if this is related.

[Gold10bucket]

I've crossed checked with mine and player with the code 3 are the ones with the African faces and 2 to the MENA faces

[6ellard]

NewGAN mistakes.zip

I have encountered similar problems, but it is pockets of players assigned wrong ethnicity faces.

It is less easy to spot with all the white categories or with nations like France, England and Brazil with a large racial variety, but you can more easily spot it with Asian or African players having very evidently wrong faces assigned. I have uploaded the last config file and the txt it used to generate it, along with a small list of very evidently wrongly assigned faces from a list of 350 players in my player search window.

I assume it is an issue that arises from the allow duplicates function of the file (I have 290.000 regens in the db) and that the program starts assigning any unused faces when it 'runs out' of the correct ethnicity ones to assign. Is my assumption correct?

PS the first line in the config file I also had to add manually, it belongs to a regen I signed for my club, but the program would not assign a face to him.

[6ellard]

Face bug #2.zip I have done a test on a small rtf with the players in the list, and I see two issues (Teszt.rtf for input) the config correct.xml contains the generated file with the lines pasted in with a tab underneath them from the original large config file

1) some of them get assigned wrong faces from the get-go (Southeast Asian Peruans? there are a few Japanese there, but they will not be called Salazar and Leguia; South American Turks?)

2) some of them get assigned the wrong ethnicity from the outset (Middle Eastern South Korean, Asian Mozambiquian, Caucasian Ivorian)