Maradonna90 / NewGAN-Manager

A tool to generate and manage xml configs for the Newgen Facepack.
GNU General Public License v3.0
171 stars 34 forks source link

feat: fixing regex to allow player id's length 5 #185

Closed humarkx closed 9 months ago

humarkx commented 9 months ago

This allows id's shorter than 7 to be parsed:

2023-11-18 18:23:14,678 | NewGAN App: 0/4: ['250591', 'ISR', None, '1'], MENA, None
2023-11-18 18:23:14,678 | NewGAN App: 1/4: ['250590', 'ITA', None, '1'], Italmed, None
2023-11-18 18:23:14,678 | NewGAN App: 2/4: ['2002092167', 'BRA', None, '1'], South American, None
2023-11-18 18:23:14,678 | NewGAN App: 3/4: ['2002092165', 'ISR', None, '1'], MENA, None

@Maradonna90 if you could merge this, it will fix for FM2024

Maradonna90 commented 9 months ago

not really what we need. We don't want to map images to potentially real players

gert-dubois commented 8 months ago

not really what we need. We don't want to map images to potentially real players

Should this not be prevented through the use of the correct filter when exporting the players?

Personally I have used the NEWGAN tool to map faces from real players to NEWGAN faces several times (for example when they were missing in my facepack). With the "r-" prefix my usecase became a lot harder, but it also means that regardless of the length of the UID of the player it's impossible to map to "real players", since those are still mapped to the the UID without prefix in the config