search

Marak / colors.js

get colors in your node.js console
https://github.com/Marak/colors.js
Other
5.17k stars 446 forks source link

Added support for orange and bgOrange #142

Open abhishekc-sharma opened 9 years ago

abhishekc-sharma commented 9 years ago

Fixes #123

petrosagg commented 9 years ago

+1, halloween is near

ryanmurakami commented 8 years ago

+1

mikeerickson commented 8 years ago

Was this ever merged?

mikeerickson commented 7 years ago

@portgasd666 Was this ever merged? If not, is there a branch which has this added?

ORESoftware commented 7 years ago

somebody click "merge"

Andrews54757 commented 7 years ago

Doesnt work for my computer. And ansi code 38 is fully supported for my machine

DABH commented 6 years ago

Is there some reason orange isn't always supportable? See comments at bottom of #123 ... generally this seems like it should be merged, but feels like a little extra clarity is needed (either here, in the docs, etc.) about why orange is different and why it might/might not work in different environments...

ORESoftware commented 6 years ago

@Marak please merge thx

DABH commented 6 years ago

Orange is not an ANSI color, would something like #76 be preferred? (Just all-out support custom colors... why stop at orange...)

Marak commented 6 years ago

I'm guessing if certain colors and styles work on some systems ( but not all systems ), we should consider adding the API methods.

For example, if orange method is supported for some shells we should allow that color. If a user attempts to use orange in a non-supported environment, we could produce a warning message based on feature detection of the environment.

I'm guessing for additional colors we'll want to add true color / 24 bit color mode. Maybe look at https://github.com/irisli/fullcolor for inspiration. Might make sense to wrap all this under that functionality.

Marak commented 6 years ago

see: https://gist.github.com/XVilka/8346728 for more details

mesqueeb commented 6 years ago

+1 for orange!