Custom Themes Buggy

[dishad]

It seems that the current version of colors has made the use of custom themes buggy. I believe that this started occurring for versions > 1.2.1.

Example:

var colors = require('colors');
colors.setTheme({
  warn: 'yellow',
  error: 'red',
  success: 'green',
  info: 'blue',
  exit: 'bold'
});

console.log('Hello success!'.success);
console.log('Hello error!'.error);
console.log('Hello warn!'.warn);
console.log('Hello info!'.info);
console.log('Hello exit!'.exit);

console.log('Hello green!'.green);
console.log('Hello red!'.red);
console.log('Hello yellow!'.yellow);
console.log('Hello blue!'.blue);
console.log('Hello bold!'.bold);

will result in:

[Marak]

@DABH ?

[DABH]

Investigating, will have an update shortly...

[DABH]

This has been fixed in v1.2.4 via https://github.com/Marak/colors.js/commit/855e342c9e26ab3d7232506cc42c240b7d800bf1 . The args there are String objects not string literals. Would be great to get to a place where no String objects appear in the codebase but we should be good for now at least. Thanks for bringing up this issue!