Marak / colors.js

get colors in your node.js console
https://github.com/Marak/colors.js
Other
5.17k stars 446 forks source link

Why are string arugments objects not literals? #227

Open DABH opened 6 years ago

DABH commented 6 years ago

In applyStyle(), the arguments are String objects, not string literals (see https://github.com/Marak/colors.js/commit/7f146faff3e1b24a845587c07745b9ea0b864f62). We should either get to the bottom of why this is the case, or, if possible, make everything string literals. String objects are discouraged and can cause surprising issues (like typeof returning 'object' not 'string').