search

Marak / colors.js

get colors in your node.js console
https://github.com/Marak/colors.js
Other
5.17k stars 446 forks source link

`__defineGetter__` to`Object.defineProperty` #237

Closed ForJing closed 5 years ago

ForJing commented 6 years ago

This feature is deprecated in favor of defining getters using the object initializer syntax or the Object.defineProperty() API. While this feature is widely implemented, it is only described in the ECMAScript specification because of legacy usage. This method should not be used since better alternatives exist. --MDN

DABH commented 6 years ago

Happy to consider this if you can make all the CI tests pass. Please also make sure that your PR goes to the develop branch, not the master branch. Thanks!

Marak commented 6 years ago

Last I remembered using Object.defineProperty broke everything horribly.

Be warned if making this change to test throughly. It didn't work last time we tried.

DABH commented 6 years ago

Indeed! Might not be able to get CI to pass this, I am fine with it either way but we should definitely be stringent with tests here.

DABH commented 5 years ago

closing due to inactivity