search

Marak / colors.js

get colors in your node.js console
https://github.com/Marak/colors.js
Other
5.17k stars 446 forks source link

Allow --no-colors through ENV instead of just CLI args #240

Closed mearns closed 5 years ago

mearns commented 6 years ago

It would be great to support disabling of colors, as currently done with the --no-colors, through an environment variable. For instance, if an environment variable named NO_COLORS is defined, disable colors.

DABH commented 6 years ago

Sure, we have FORCE_COLORS right now for forcing colors to be enabled, we could add FORCE_NO_COLORS (I would be happy to review a PR). Just figure out what should happen if both FORCE_COLORS and FORCE_NO_COLORS were set in a user's environment :)

mearns commented 6 years ago

👍 I submitted a PR for this; I'm definitely open to any feedback on functionality or styling, just let me know =)

DABH commented 5 years ago

merged #21!